[improvement](release) add release download scripts by morningman · Pull Request #18703 · apache/doris

morningman · 2023-04-16T07:19:09Z

Proposed changes

Issue Number: close #xxx

Problem summary

Motivation

For now, there are 3 packages for the release binaries of Doris: https://doris.apache.org/download
And user may be confused about how to download and deploy these packages.

So I provide a download script for each release, and user can simply download the script and run it, like:

> sh download_x64_apache.sh

Begin to download FE from "https://mirrors.tuna.tsinghua.edu.cn/apache/doris/1.2/1.2.3-rc02/apache-doris-fe-1.2.3-bin-x86_64.tar.xz" to "apache-doris-1.2.3-bin/" ...
Total size: 408078012 Bytes
#################################################### 100.0%
Begin to download BE from "https://mirrors.tuna.tsinghua.edu.cn/apache/doris/1.2/1.2.3-rc02/apache-doris-be-1.2.3-bin-x86_64.tar.xz" to "apache-doris-1.2.3-bin/" ...
Total size: 606211324 Bytes
#################################################### 100.0%
Begin to download DEPS from "https://mirrors.tuna.tsinghua.edu.cn/apache/doris/1.2/1.2.3-rc02/apache-doris-dependencies-1.2.3-bin-x86_64.tar.xz" to "apache-doris-1.2.3-bin/" ...
Total size: 253869148 Bytes
#################################################### 100.0%
Begin to assemble the binaries ...
Move java-udf-jar-with-dependencies.jar to be/lib/ ...
Download complete!
You can now deploy Apache Doris from apache-doris-1.2.3-bin/

The script will do the rest.

This script will later be published on the Download page of Apache Doris website, so that user can easily get
it and use it.

Currently only for Linux platform. Other platform is untested.

Checklist(Required)

Does it affect the original behavior
Has unit tests been added
Has document been added or modified
Does it need to update dependencies
Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

github-actions · 2023-04-16T07:20:09Z

`sh-checker report`

To get the full details, please check in the job output.

shellcheck errors


'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In dist/download_scripts/1.2.3/download_arm_apache.sh line 21:
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
^--^ SC2034 (warning): ROOT appears unused. Verify use (or export if used externally).


In dist/download_scripts/1.2.3/download_arm_apache.sh line 32:
if [ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]; then
   ^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.

Did you mean: 
if [[ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]]; then


In dist/download_scripts/1.2.3/download_arm_apache.sh line 34:
        && chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
                     ^----------------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
        && chmod a+x "${DOWNLOAD_BASE_SCRIPTS}"


In dist/download_scripts/1.2.3/download_arm_apache.sh line 38:
./${DOWNLOAD_BASE_SCRIPTS} "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"
  ^----------------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
./"${DOWNLOAD_BASE_SCRIPTS}" "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"


In dist/download_scripts/1.2.3/download_arm_tsinghua.sh line 21:
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
^--^ SC2034 (warning): ROOT appears unused. Verify use (or export if used externally).


In dist/download_scripts/1.2.3/download_arm_tsinghua.sh line 32:
if [ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]; then
   ^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.

Did you mean: 
if [[ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]]; then


In dist/download_scripts/1.2.3/download_arm_tsinghua.sh line 34:
        && chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
                     ^----------------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
        && chmod a+x "${DOWNLOAD_BASE_SCRIPTS}"


In dist/download_scripts/1.2.3/download_arm_tsinghua.sh line 38:
./${DOWNLOAD_BASE_SCRIPTS} "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"
  ^----------------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
./"${DOWNLOAD_BASE_SCRIPTS}" "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"


In dist/download_scripts/1.2.3/download_x64_apache.sh line 21:
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
^--^ SC2034 (warning): ROOT appears unused. Verify use (or export if used externally).


In dist/download_scripts/1.2.3/download_x64_apache.sh line 32:
if [ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]; then
   ^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.

Did you mean: 
if [[ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]]; then


In dist/download_scripts/1.2.3/download_x64_apache.sh line 34:
        && chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
                     ^----------------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
        && chmod a+x "${DOWNLOAD_BASE_SCRIPTS}"


In dist/download_scripts/1.2.3/download_x64_apache.sh line 38:
./${DOWNLOAD_BASE_SCRIPTS} "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"
  ^----------------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
./"${DOWNLOAD_BASE_SCRIPTS}" "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"


In dist/download_scripts/1.2.3/download_x64_noavx2_apache.sh line 21:
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
^--^ SC2034 (warning): ROOT appears unused. Verify use (or export if used externally).


In dist/download_scripts/1.2.3/download_x64_noavx2_apache.sh line 32:
if [ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]; then
   ^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.

Did you mean: 
if [[ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]]; then


In dist/download_scripts/1.2.3/download_x64_noavx2_apache.sh line 34:
        && chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
                     ^----------------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
        && chmod a+x "${DOWNLOAD_BASE_SCRIPTS}"


In dist/download_scripts/1.2.3/download_x64_noavx2_apache.sh line 38:
./${DOWNLOAD_BASE_SCRIPTS} "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"
  ^----------------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
./"${DOWNLOAD_BASE_SCRIPTS}" "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"


In dist/download_scripts/1.2.3/download_x64_noavx2_tsinghua.sh line 21:
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
^--^ SC2034 (warning): ROOT appears unused. Verify use (or export if used externally).


In dist/download_scripts/1.2.3/download_x64_noavx2_tsinghua.sh line 32:
if [ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]; then
   ^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.

Did you mean: 
if [[ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]]; then


In dist/download_scripts/1.2.3/download_x64_noavx2_tsinghua.sh line 34:
        && chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
                     ^----------------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
        && chmod a+x "${DOWNLOAD_BASE_SCRIPTS}"


In dist/download_scripts/1.2.3/download_x64_noavx2_tsinghua.sh line 38:
./${DOWNLOAD_BASE_SCRIPTS} "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"
  ^----------------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
./"${DOWNLOAD_BASE_SCRIPTS}" "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"


In dist/download_scripts/1.2.3/download_x64_tsinghua.sh line 21:
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
^--^ SC2034 (warning): ROOT appears unused. Verify use (or export if used externally).


In dist/download_scripts/1.2.3/download_x64_tsinghua.sh line 32:
if [ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]; then
   ^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.

Did you mean: 
if [[ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]]; then


In dist/download_scripts/1.2.3/download_x64_tsinghua.sh line 34:
        && chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
                     ^----------------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
        && chmod a+x "${DOWNLOAD_BASE_SCRIPTS}"


In dist/download_scripts/1.2.3/download_x64_tsinghua.sh line 38:
./${DOWNLOAD_BASE_SCRIPTS} "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"
  ^----------------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
./"${DOWNLOAD_BASE_SCRIPTS}" "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"


In dist/download_scripts/download_base.sh line 35:
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
^--^ SC2034 (warning): ROOT appears unused. Verify use (or export if used externally).


In dist/download_scripts/download_base.sh line 46:
if [ $? -ne 0 ]; then
   ^----------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
     ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.

Did you mean: 
if [[ $? -ne 0 ]]; then


In dist/download_scripts/download_base.sh line 52:
if [ -f "${DOWNLOAD_DIR}" -o -d "${DOWNLOAD_DIR}" ]; then
   ^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
                          ^-- SC2166 (warning): Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.


In dist/download_scripts/download_base.sh line 53:
    read -p "Download dir ${DOWNLOAD_DIR} already exists. Overwrite? [y/n] " resp
    ^--^ SC2162 (info): read without -r will mangle backslashes.


In dist/download_scripts/download_base.sh line 54:
    if [ "${resp}" = "y" -o "${resp}" = "Y" ]
       ^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
                         ^-- SC2166 (warning): Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.


In dist/download_scripts/download_base.sh line 81:
download "FE" ${FE_LINK} ${DOWNLOAD_DIR}
              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
download "FE" "${FE_LINK}" "${DOWNLOAD_DIR}"


In dist/download_scripts/download_base.sh line 82:
download "BE" ${BE_LINK} ${DOWNLOAD_DIR}
              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
download "BE" "${BE_LINK}" "${DOWNLOAD_DIR}"


In dist/download_scripts/download_base.sh line 83:
download "DEPS" ${DEPS_LINK} ${DOWNLOAD_DIR}
                ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                             ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
download "DEPS" "${DEPS_LINK}" "${DOWNLOAD_DIR}"

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- ROOT appears unused. Verify use (...
  https://www.shellcheck.net/wiki/SC2166 -- Prefer [ p ] || [ q ] as [ p -o q...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.

shfmt errors


'shfmt ' returned error 1 finding the following formatting issues:

----------
--- dist/download_scripts/1.2.3/download_arm_apache.sh.orig
+++ dist/download_scripts/1.2.3/download_arm_apache.sh
@@ -30,10 +30,9 @@
 DOWNLOAD_BASE_SCRIPTS="download_base.sh"
 
 if [ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]; then
-   curl -O https://raw.githubusercontent.com/apache/doris/master/dist/download_scripts/download_base.sh \
-        && chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
+    curl -O https://raw.githubusercontent.com/apache/doris/master/dist/download_scripts/download_base.sh &&
+        chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
 fi
 
 # Begin to download
 ./${DOWNLOAD_BASE_SCRIPTS} "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"
-
--- dist/download_scripts/1.2.3/download_arm_tsinghua.sh.orig
+++ dist/download_scripts/1.2.3/download_arm_tsinghua.sh
@@ -30,10 +30,9 @@
 DOWNLOAD_BASE_SCRIPTS="download_base.sh"
 
 if [ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]; then
-   curl -O https://raw.githubusercontent.com/apache/doris/master/dist/download_scripts/download_base.sh \
-        && chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
+    curl -O https://raw.githubusercontent.com/apache/doris/master/dist/download_scripts/download_base.sh &&
+        chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
 fi
 
 # Begin to download
 ./${DOWNLOAD_BASE_SCRIPTS} "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"
-
--- dist/download_scripts/1.2.3/download_x64_apache.sh.orig
+++ dist/download_scripts/1.2.3/download_x64_apache.sh
@@ -30,10 +30,9 @@
 DOWNLOAD_BASE_SCRIPTS="download_base.sh"
 
 if [ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]; then
-   curl -O https://raw.githubusercontent.com/apache/doris/master/dist/download_scripts/download_base.sh \
-        && chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
+    curl -O https://raw.githubusercontent.com/apache/doris/master/dist/download_scripts/download_base.sh &&
+        chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
 fi
 
 # Begin to download
 ./${DOWNLOAD_BASE_SCRIPTS} "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"
-
--- dist/download_scripts/1.2.3/download_x64_noavx2_apache.sh.orig
+++ dist/download_scripts/1.2.3/download_x64_noavx2_apache.sh
@@ -30,10 +30,9 @@
 DOWNLOAD_BASE_SCRIPTS="download_base.sh"
 
 if [ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]; then
-   curl -O https://raw.githubusercontent.com/apache/doris/master/dist/download_scripts/download_base.sh \
-        && chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
+    curl -O https://raw.githubusercontent.com/apache/doris/master/dist/download_scripts/download_base.sh &&
+        chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
 fi
 
 # Begin to download
 ./${DOWNLOAD_BASE_SCRIPTS} "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"
-
--- dist/download_scripts/1.2.3/download_x64_noavx2_tsinghua.sh.orig
+++ dist/download_scripts/1.2.3/download_x64_noavx2_tsinghua.sh
@@ -30,10 +30,9 @@
 DOWNLOAD_BASE_SCRIPTS="download_base.sh"
 
 if [ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]; then
-   curl -O https://raw.githubusercontent.com/apache/doris/master/dist/download_scripts/download_base.sh \
-        && chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
+    curl -O https://raw.githubusercontent.com/apache/doris/master/dist/download_scripts/download_base.sh &&
+        chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
 fi
 
 # Begin to download
 ./${DOWNLOAD_BASE_SCRIPTS} "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"
-
--- dist/download_scripts/1.2.3/download_x64_tsinghua.sh.orig
+++ dist/download_scripts/1.2.3/download_x64_tsinghua.sh
@@ -30,10 +30,9 @@
 DOWNLOAD_BASE_SCRIPTS="download_base.sh"
 
 if [ ! -f "${DOWNLOAD_BASE_SCRIPTS}" ]; then
-   curl -O https://raw.githubusercontent.com/apache/doris/master/dist/download_scripts/download_base.sh \
-        && chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
+    curl -O https://raw.githubusercontent.com/apache/doris/master/dist/download_scripts/download_base.sh &&
+        chmod a+x ${DOWNLOAD_BASE_SCRIPTS}
 fi
 
 # Begin to download
 ./${DOWNLOAD_BASE_SCRIPTS} "${FE}" "${BE}" "${DEPS}" "${DOWNLOAD_LINK_PREFIX}" "${DOWNLOAD_DIR}"
-
--- dist/download_scripts/download_base.sh.orig
+++ dist/download_scripts/download_base.sh
@@ -27,7 +27,7 @@
 #       apache-doris-dependencies-1.2.3-bin-x86_64                          \
 #       https://mirrors.tuna.tsinghua.edu.cn/apache/doris/1.2/1.2.3-rc02/   \
 #       apache-doris-1.2.3-bin
- 
+
 ###############################################################################
 
 set -eo pipefail
@@ -42,7 +42,7 @@
 FILE_SUFFIX=".tar.xz"
 
 # Check if curl cmd exists
-which curl > /dev/null 2>&1
+which curl >/dev/null 2>&1
 if [ $? -ne 0 ]; then
     echo "curl command not found on the system"
     exit 1
@@ -51,8 +51,7 @@
 # Check download dir
 if [ -f "${DOWNLOAD_DIR}" -o -d "${DOWNLOAD_DIR}" ]; then
     read -p "Download dir ${DOWNLOAD_DIR} already exists. Overwrite? [y/n] " resp
-    if [ "${resp}" = "y" -o "${resp}" = "Y" ]
-    then
+    if [ "${resp}" = "y" -o "${resp}" = "Y" ]; then
         rm -rf "${DOWNLOAD_DIR}"
         echo "Origin ${DOWNLOAD_DIR} has been removed and created a new one".
     else
@@ -90,4 +89,3 @@
 
 echo "Download complete!"
 echo "You can now deploy Apache Doris from ${DOWNLOAD_DIR}/"
-
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename

github-actions · 2023-04-16T08:00:42Z

`sh-checker report`

To get the full details, please check in the job output.

shellcheck errors


'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In dist/download_scripts/download_base.sh line 42:
if [[ ! $(which curl >/dev/null 2>&1) ]]; then
        ^---------------------------^ SC2243 (style): Prefer explicit -n to check for output (or run command without [/[[ to check for success).

Did you mean: 
if [[ ! -n $(which curl >/dev/null 2>&1) ]]; then


In dist/download_scripts/download_base.sh line 49:
    read -p "Download dir ${DOWNLOAD_DIR} already exists. Overwrite? [y/n] " resp
    ^--^ SC2162 (info): read without -r will mangle backslashes.

For more information:
  https://www.shellcheck.net/wiki/SC2162 -- read without -r will mangle backs...
  https://www.shellcheck.net/wiki/SC2243 -- Prefer explicit -n to check for o...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.

shfmt errors


'shfmt ' returned error 1 finding the following formatting issues:

----------
--- dist/download_scripts/download_base.sh.orig
+++ dist/download_scripts/download_base.sh
@@ -85,4 +85,3 @@
 
 echo "Download complete!"
 echo "You can now deploy Apache Doris from ${DOWNLOAD_DIR}/"
-
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename

github-actions · 2023-04-16T08:03:16Z

`sh-checker report`

To get the full details, please check in the job output.

shellcheck errors


'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In dist/download_scripts/download_base.sh line 49:
    read -p "Download dir ${DOWNLOAD_DIR} already exists. Overwrite? [y/n] " resp
    ^--^ SC2162 (info): read without -r will mangle backslashes.

For more information:
  https://www.shellcheck.net/wiki/SC2162 -- read without -r will mangle backs...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.

shfmt errors


'shfmt ' returned error 1 finding the following formatting issues:

----------
--- dist/download_scripts/download_base.sh.orig
+++ dist/download_scripts/download_base.sh
@@ -85,4 +85,3 @@
 
 echo "Download complete!"
 echo "You can now deploy Apache Doris from ${DOWNLOAD_DIR}/"
-
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename

github-actions · 2023-04-16T08:06:25Z

`sh-checker report`

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' found no issues.

shfmt errors


'shfmt ' returned error 1 finding the following formatting issues:

----------
--- dist/download_scripts/download_base.sh.orig
+++ dist/download_scripts/download_base.sh
@@ -86,4 +86,3 @@
 
 echo "Download complete!"
 echo "You can now deploy Apache Doris from ${DOWNLOAD_DIR}/"
-
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename

github-actions · 2023-04-16T08:24:52Z

`sh-checker report`

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' found no issues.

shfmt errors


'shfmt ' returned error 1 finding the following formatting issues:

----------
--- dist/download_scripts/download_base.sh.orig
+++ dist/download_scripts/download_base.sh
@@ -86,4 +86,3 @@
 
 echo "Download complete!"
 echo "You can now deploy Apache Doris from ${DOWNLOAD_DIR}/"
-
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename

github-actions · 2023-04-16T08:24:59Z

`sh-checker report`

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' found no issues.

shfmt errors


'shfmt ' returned error 1 finding the following formatting issues:

----------
--- dist/download_scripts/download_base.sh.orig
+++ dist/download_scripts/download_base.sh
@@ -86,4 +86,3 @@
 
 echo "Download complete!"
 echo "You can now deploy Apache Doris from ${DOWNLOAD_DIR}/"
-
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename

morningman · 2023-04-16T08:27:26Z

run buildall

luzhijing

LGTM

github-actions · 2023-04-16T08:37:07Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-04-16T08:37:10Z

PR approved by anyone and no changes requested.

For now, there are 3 packages for the release binaries of Doris: https://doris.apache.org/download And user may be confused about how to download and deploy these packages. So I provide a download script for each release, and user can simply download the script and run it, like: ``` > sh download_x64_apache.sh Begin to download FE from "https://mirrors.tuna.tsinghua.edu.cn/apache/doris/1.2/1.2.3-rc02/apache-doris-fe-1.2.3-bin-x86_64.tar.xz" to "apache-doris-1.2.3-bin/" ... Total size: 408078012 Bytes #################################################### 100.0% Begin to download BE from "https://mirrors.tuna.tsinghua.edu.cn/apache/doris/1.2/1.2.3-rc02/apache-doris-be-1.2.3-bin-x86_64.tar.xz" to "apache-doris-1.2.3-bin/" ... Total size: 606211324 Bytes #################################################### 100.0% Begin to download DEPS from "https://mirrors.tuna.tsinghua.edu.cn/apache/doris/1.2/1.2.3-rc02/apache-doris-dependencies-1.2.3-bin-x86_64.tar.xz" to "apache-doris-1.2.3-bin/" ... Total size: 253869148 Bytes #################################################### 100.0% Begin to assemble the binaries ... Move java-udf-jar-with-dependencies.jar to be/lib/ ... Download complete! You can now deploy Apache Doris from apache-doris-1.2.3-bin/ ``` The script will do the rest. This script will later be published on the Download page of Apache Doris website, so that user can easily get it and use it. Currently only for Linux platform. Other platform is untested.

morningman added 5 commits April 16, 2023 16:23

[improvement](release) add release download scripts

ac4b9f0

style

ab69fc5

style 2

4d16ad7

style 2

dbd632c

style 2

efa74bb

morningman force-pushed the download_sh branch from 7ee7b1e to efa74bb Compare April 16, 2023 08:24

style 2

ebe08b2

morningman added dev/1.2.4 usercase Important user case type label labels Apr 16, 2023

luzhijing approved these changes Apr 16, 2023

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 16, 2023

github-actions bot added the reviewed label Apr 16, 2023

morningman merged commit 70a418c into apache:master Apr 16, 2023

morningman added dev/1.2.4-merged and removed dev/1.2.4 labels Apr 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[improvement](release) add release download scripts#18703

[improvement](release) add release download scripts#18703
morningman merged 6 commits intoapache:masterfrom
morningman:download_sh

morningman commented Apr 16, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Apr 16, 2023

Uh oh!

github-actions bot commented Apr 16, 2023

Uh oh!

github-actions bot commented Apr 16, 2023

Uh oh!

github-actions bot commented Apr 16, 2023

Uh oh!

github-actions bot commented Apr 16, 2023

Uh oh!

github-actions bot commented Apr 16, 2023

Uh oh!

morningman commented Apr 16, 2023

Uh oh!

luzhijing left a comment

Uh oh!

github-actions bot commented Apr 16, 2023

Uh oh!

github-actions bot commented Apr 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

morningman commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Problem summary

Motivation

Checklist(Required)

Further comments

Uh oh!

github-actions bot commented Apr 16, 2023

sh-checker report

Uh oh!

github-actions bot commented Apr 16, 2023

sh-checker report

Uh oh!

github-actions bot commented Apr 16, 2023

sh-checker report

Uh oh!

github-actions bot commented Apr 16, 2023

sh-checker report

Uh oh!

github-actions bot commented Apr 16, 2023

sh-checker report

Uh oh!

github-actions bot commented Apr 16, 2023

sh-checker report

Uh oh!

morningman commented Apr 16, 2023

Uh oh!

luzhijing left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 16, 2023

Uh oh!

github-actions bot commented Apr 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

morningman commented Apr 16, 2023 •

edited

Loading

`sh-checker report`

`sh-checker report`

`sh-checker report`

`sh-checker report`

`sh-checker report`

`sh-checker report`