[feature](graph)Support querying data from the Nebula graph database#18769
Closed
chenlinzhong wants to merge 3 commits intoapache:masterfrom
chenlinzhong:feature_graph
Closed
[feature](graph)Support querying data from the Nebula graph database#18769chenlinzhong wants to merge 3 commits intoapache:masterfrom chenlinzhong:feature_graph
chenlinzhong wants to merge 3 commits intoapache:masterfrom
chenlinzhong:feature_graph
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
Is it too simple to use |
| for (int i = 0; i < columnCount; ++i) { | ||
| block.get(i)[curBlockRows] = resultSet.getObject(i + 1); | ||
| if (isGraph()) { | ||
| block.get(i)[curBlockRows] = tranferToDorisObject((ValueWrapper) resultSet.getObject(i + 1)); |
Contributor
There was a problem hiding this comment.
maybe can't at here to convert, it's will be exectue low efficiency
Contributor
Author
In the field of graphs, the variable g is usually used to execute GQL, so it is best to keep their usage consistent and simple here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem summary
Support querying data from the Nebula graph database
This feature comes from the needs of commercial customers who have used Doris and Nebula, hoping to connect these two databases
changes mainly include:
How to use ?
Nebula-graph type map
NebulaGraphTest (仅支持查询)
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...