Skip to content

[fix](nereids) disable_join_reorder does not work with semi/anti#18898

Merged
englefly merged 1 commit intoapache:masterfrom
englefly:dis
Apr 25, 2023
Merged

[fix](nereids) disable_join_reorder does not work with semi/anti#18898
englefly merged 1 commit intoapache:masterfrom
englefly:dis

Conversation

@englefly
Copy link
Contributor

Proposed changes

semi/anti push rules should not work if disable_join_reorder = true;

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@englefly
Copy link
Contributor Author

run buildall

starocean999
starocean999 previously approved these changes Apr 23, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 23, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@englefly
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 24, 2023
@englefly
Copy link
Contributor Author

run buildall

Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify getExplorationRules()

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 25, 2023
@englefly englefly merged commit e2afa07 into apache:master Apr 25, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 25, 2023
…he#18898

semi/anti push rules should not work if disable_join_reorder = true;
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
…he#18898

semi/anti push rules should not work if disable_join_reorder = true;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/nereids reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants