Skip to content

Comments

[bugfix](jsonb) fix jsonb parser crash on noavx2 host#18977

Merged
morningman merged 3 commits intoapache:masterfrom
xiaokang:fix_jsonb_noavx2
Apr 26, 2023
Merged

[bugfix](jsonb) fix jsonb parser crash on noavx2 host#18977
morningman merged 3 commits intoapache:masterfrom
xiaokang:fix_jsonb_noavx2

Conversation

@xiaokang
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

support avx2 and noavx2 for jsonb parser using __AVX2__ macro.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Apr 23, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei
Copy link
Contributor

run buildall

yiguolei
yiguolei previously approved these changes Apr 23, 2023
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 23, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 23, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.06 seconds
stream load tsv: 426 seconds loaded 74807831229 Bytes, about 167 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230426060218_clickbench_pr_135448.html

@xiaokang
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 25, 2023
@xiaokang
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the usercase Important user case type label label Apr 26, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 26, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 1dfc5ea into apache:master Apr 26, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 27, 2023
support avx2 and noavx2 for jsonb parser using __AVX2__ macro.
xiaokang added a commit to xiaokang/doris that referenced this pull request Apr 28, 2023
…#18977)"

This reverts commit c6ea8cdb84f668b7c2461a16de533eec7962d874.
xiaokang added a commit to xiaokang/doris that referenced this pull request May 9, 2023
support avx2 and noavx2 for jsonb parser using __AVX2__ macro.
morningman pushed a commit that referenced this pull request May 10, 2023
support avx2 and noavx2 for jsonb parser using __AVX2__ macro.
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
support avx2 and noavx2 for jsonb parser using __AVX2__ macro.
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
…pache#19454)

support avx2 and noavx2 for jsonb parser using __AVX2__ macro.
gnehil pushed a commit to gnehil/doris that referenced this pull request Jul 13, 2023
…#18977)"

This reverts commit c6ea8cdb84f668b7c2461a16de533eec7962d874.
gnehil pushed a commit to gnehil/doris that referenced this pull request Jul 25, 2023
…#18977)"

This reverts commit c6ea8cdb84f668b7c2461a16de533eec7962d874.
gnehil pushed a commit to gnehil/doris that referenced this pull request Aug 15, 2023
…#18977)"

This reverts commit c6ea8cdb84f668b7c2461a16de533eec7962d874.
gnehil pushed a commit to gnehil/doris that referenced this pull request Aug 16, 2023
…#18977)"

This reverts commit c6ea8cdb84f668b7c2461a16de533eec7962d874.
gnehil pushed a commit to gnehil/doris that referenced this pull request Aug 29, 2023
…#18977)"

This reverts commit c6ea8cdb84f668b7c2461a16de533eec7962d874.
gnehil pushed a commit to gnehil/doris that referenced this pull request Sep 1, 2023
…#18977)"

This reverts commit c6ea8cdb84f668b7c2461a16de533eec7962d874.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions area/vectorization dev/1.2.5-merged need-cherry-pick reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants