Skip to content

[fix](phmap) Make PHHashMap exception safety #19076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrhhsg wants to merge 1 commit into from
Closed

[fix](phmap) Make PHHashMap exception safety #19076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 38 additions & 18 deletions be/src/vec/common/hash_table/ph_hash_map.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,16 @@ class PHHashMap : private boost::noncopyable {
void ALWAYS_INLINE emplace(KeyHolder&& key_holder, LookupResult& it, bool& inserted) {
const auto& key = key_holder_get_key(key_holder);
inserted = false;
it = &*_hash_map.lazy_emplace(key, [&](const auto& ctor) {
inserted = true;
key_holder_persist_key(key_holder);
ctor(key_holder_get_key(key_holder), nullptr);
});
try {
it = &*_hash_map.lazy_emplace(key, [&](const auto& ctor) {
inserted = true;
key_holder_persist_key(key_holder);
ctor(key_holder_get_key(key_holder), nullptr);
});
} catch (std::bad_alloc const& e) {
_hash_map.erase(key);
throw e;
}

if constexpr (PartitionedHashTable) {
_check_if_need_partition();
Expand All @@ -143,10 +148,15 @@ class PHHashMap : private boost::noncopyable {
template <typename KeyHolder, typename Func>
void ALWAYS_INLINE lazy_emplace(KeyHolder&& key_holder, LookupResult& it, Func&& f) {
const auto& key = key_holder_get_key(key_holder);
it = &*_hash_map.lazy_emplace(key, [&](const auto& ctor) {
key_holder_persist_key(key_holder);
f(ctor, key);
});
try {
it = &*_hash_map.lazy_emplace(key, [&](const auto& ctor) {
key_holder_persist_key(key_holder);
f(ctor, key);
});
} catch (std::bad_alloc const& e) {
_hash_map.erase(key);
throw e;
}

if constexpr (PartitionedHashTable) {
_check_if_need_partition();
Expand All @@ -158,11 +168,16 @@ class PHHashMap : private boost::noncopyable {
bool& inserted) {
const auto& key = key_holder_get_key(key_holder);
inserted = false;
it = &*_hash_map.lazy_emplace_with_hash(key, hash_value, [&](const auto& ctor) {
inserted = true;
key_holder_persist_key(key_holder);
ctor(key, nullptr);
});
try {
it = &*_hash_map.lazy_emplace_with_hash(key, hash_value, [&](const auto& ctor) {
inserted = true;
key_holder_persist_key(key_holder);
ctor(key, nullptr);
});
} catch (std::bad_alloc const& e) {
_hash_map.erase(key);
throw e;
}

if constexpr (PartitionedHashTable) {
_check_if_need_partition();
Expand All @@ -174,10 +189,15 @@ class PHHashMap : private boost::noncopyable {
Func&& f) {
const auto& key = key_holder_get_key(key_holder);

it = &*_hash_map.lazy_emplace_with_hash(key, hash_value, [&](const auto& ctor) {
key_holder_persist_key(key_holder);
f(ctor, key);
});
try {
it = &*_hash_map.lazy_emplace_with_hash(key, hash_value, [&](const auto& ctor) {
key_holder_persist_key(key_holder);
f(ctor, key);
});
} catch (std::bad_alloc const& e) {
_hash_map.erase(key);
throw e;
}

if constexpr (PartitionedHashTable) {
_check_if_need_partition();
Expand Down