Skip to content

Comments

[fix](core) fix multi_match_any maybe core down#19089

Closed
nextdreamblue wants to merge 7 commits intoapache:masterfrom
nextdreamblue:fix_multi_match_any1
Closed

[fix](core) fix multi_match_any maybe core down#19089
nextdreamblue wants to merge 7 commits intoapache:masterfrom
nextdreamblue:fix_multi_match_any1

Conversation

@nextdreamblue
Copy link
Contributor

@nextdreamblue nextdreamblue commented Apr 26, 2023

Proposed changes

Issue Number: close #19050

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/docs Categorizes issue or PR as related to documentation. kind/test labels Apr 26, 2023
github-actions[bot]
github-actions bot reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@nextdreamblue
Copy link
Contributor Author

nextdreamblue commented Apr 26, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

clang-tidy review says "All clean, LGTM! 👍"

github-actions[bot]
github-actions bot reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 26, 2023 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.52 seconds
stream load tsv: 426 seconds loaded 74807831229 Bytes, about 167 MB/s
stream load json: 26 seconds loaded 2358488459 Bytes, about 86 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230510080139_clickbench_pr_141580.html

@nextdreamblue
Copy link
Contributor Author

nextdreamblue commented Apr 26, 2023

run p1

@morningman morningman added usercase Important user case type label dev/1.2.5 labels Apr 27, 2023
@nextdreamblue nextdreamblue force-pushed the fix_multi_match_any1 branch from 3287446 to d2bf511 Compare May 9, 2023 07:55
@nextdreamblue
Copy link
Contributor Author

nextdreamblue commented May 9, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

nextdreamblue and others added 5 commits May 9, 2023 20:55
@nextdreamblue
[fix](core) fix multi_match_any maybe core down
f7d1478 
Signed-off-by: nextdreamblue <zxw520blue1@163.com>
@nextdreamblue @github-actions
Update be/src/vec/functions/functions_multi_string_search.cpp
32648aa 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@nextdreamblue @github-actions
Update be/src/vec/functions/functions_multi_string_search.cpp
1d67469 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@nextdreamblue
fix code
2491335
@nextdreamblue
fix code 500
6dc7d1f 
Signed-off-by: nextdreamblue <zxw520blue1@163.com>
@nextdreamblue nextdreamblue force-pushed the fix_multi_match_any1 branch from 8045c3e to 6dc7d1f Compare May 9, 2023 12:55
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@nextdreamblue
fix code 600
6789830 
Signed-off-by: nextdreamblue <zxw520blue1@163.com>
@nextdreamblue
Copy link
Contributor Author

nextdreamblue commented May 9, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@nextdreamblue
Copy link
Contributor Author

nextdreamblue commented May 10, 2023

run p0

@nextdreamblue
fix code 1000
0de0a01 
Signed-off-by: nextdreamblue <zxw520blue1@163.com>
@nextdreamblue
Copy link
Contributor Author

nextdreamblue commented May 10, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

clang-tidy review says "All clean, LGTM! 👍"

@nextdreamblue
Copy link
Contributor Author

nextdreamblue commented May 11, 2023

close by #19498

@yiguolei yiguolei removed usercase Important user case type label dev/1.2.5 labels May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/docs Categorizes issue or PR as related to documentation. kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] compare multi_match_any result with 1 cause be coredump

4 participants

@nextdreamblue @hello-stephen @morningman @yiguolei