-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feature-wip](mv lifecycle) Support drop partition from index. #19234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
09820f6 to
5f00e43
Compare
fe/fe-core/src/main/java/org/apache/doris/common/ErrorCode.java
Outdated
Show resolved
Hide resolved
5f00e43 to
d91b65f
Compare
|
Thanks @dataroaring for the review. I have updated this pull request in some new commits for the convenience of review, we can squashed them when merging code. Regression test is also modified to cover this changes. Please take a look in your free time, thanks~ |
|
could we do select rollup/mv correctly after we do drop index partition? |
Sorry, I don't fully understand what you mean. Do you mean that after deleting baseIndex, can we still perform queries based on mv? |
|
run buildall |
yes, i don't see any update about mv/rollup selection, so what' will happen when we have a table with mv and some partitions of mv have been dropped? |
|
@morrySnow Good question. In this PR's implementation, only after all indexes of a partition are deleted will the partition be deleted (The effect is the same as the
If I missed something, please feel free to point me out 🙇. Also cc @dataroaring for the more advanced insights. |
d91b65f to
bd0db32
Compare
bd0db32 to
f054dec
Compare
Proposed changes
Issue Number: partially close #18505
Problem summary
Describe your changes.
Checklist(Required)
Further comments