Skip to content

Comments

[refactor](scan) avoid unnecessary function call#19299

Merged
yiguolei merged 3 commits intoapache:masterfrom
Gabriel39:refactor_bthread_scanner
May 6, 2023
Merged

[refactor](scan) avoid unnecessary function call#19299
yiguolei merged 3 commits intoapache:masterfrom
Gabriel39:refactor_bthread_scanner

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented May 5, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

@Gabriel39
Copy link
Contributor Author

Gabriel39 commented May 5, 2023

run buildall

@Gabriel39 Gabriel39 changed the title [Improvement](scan) avoid unnecessary function call [refactor](scan) avoid unnecessary function call May 5, 2023
@Gabriel39 Gabriel39 closed this May 5, 2023
@Gabriel39 Gabriel39 reopened this May 5, 2023
@Gabriel39
Copy link
Contributor Author

Gabriel39 commented May 5, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented May 5, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.38 seconds
stream load tsv: 425 seconds loaded 74807831229 Bytes, about 167 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230505115429_clickbench_pr_138738.html

yiguolei
yiguolei approved these changes May 6, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 811ba73 into apache:master May 6, 2023
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
@Gabriel39 @Reminiscent
[refactor](scan) avoid unnecessary function call (apache#19299)
49ed204 
* [Improvement](scan) avoid unnecessary function call

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gabriel39 @hello-stephen @yiguolei