[Inprovement](consts): Use inline variable#19301
[Inprovement](consts): Use inline variable#19301happysnaker wants to merge 1 commit intoapache:masterfrom happysnaker:master
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__"; | ||
| const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__"; | ||
|
|
||
| inline const std::string CSV = "csv"; |
There was a problem hiding this comment.
warning: inline variables are a C++17 extension [clang-diagnostic-c++17-extensions]
inline const std::string CSV = "csv";
^| const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__"; | ||
|
|
||
| inline const std::string CSV = "csv"; | ||
| inline const std::string CSV_WITH_NAMES = "csv_with_names"; |
There was a problem hiding this comment.
warning: inline variables are a C++17 extension [clang-diagnostic-c++17-extensions]
inline const std::string CSV_WITH_NAMES = "csv_with_names";
^|
|
||
| inline const std::string CSV = "csv"; | ||
| inline const std::string CSV_WITH_NAMES = "csv_with_names"; | ||
| inline const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types"; |
There was a problem hiding this comment.
warning: inline variables are a C++17 extension [clang-diagnostic-c++17-extensions]
inline const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
^| inline const std::string CSV = "csv"; | ||
| inline const std::string CSV_WITH_NAMES = "csv_with_names"; | ||
| inline const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types"; | ||
| inline const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__"; |
There was a problem hiding this comment.
warning: inline variables are a C++17 extension [clang-diagnostic-c++17-extensions]
inline const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
^| inline const std::string CSV_WITH_NAMES = "csv_with_names"; | ||
| inline const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types"; | ||
| inline const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__"; | ||
| inline const std::string ROWID_COL = "__DORIS_ROWID_COL__"; |
There was a problem hiding this comment.
warning: inline variables are a C++17 extension [clang-diagnostic-c++17-extensions]
inline const std::string ROWID_COL = "__DORIS_ROWID_COL__";
^| inline const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types"; | ||
| inline const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__"; | ||
| inline const std::string ROWID_COL = "__DORIS_ROWID_COL__"; | ||
| inline const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__"; |
There was a problem hiding this comment.
warning: inline variables are a C++17 extension [clang-diagnostic-c++17-extensions]
inline const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
^| inline const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__"; | ||
| inline const std::string ROWID_COL = "__DORIS_ROWID_COL__"; | ||
| inline const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__"; | ||
| inline const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__"; |
There was a problem hiding this comment.
warning: inline variables are a C++17 extension [clang-diagnostic-c++17-extensions]
inline const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
^| constexpr int MAX_DECIMAL32_PRECISION = 9; | ||
| constexpr int MAX_DECIMAL64_PRECISION = 18; | ||
| constexpr int MAX_DECIMAL128_PRECISION = 38; | ||
| inline constexpr int MAX_DECIMAL32_PRECISION = 9; |
There was a problem hiding this comment.
warning: inline variables are a C++17 extension [clang-diagnostic-c++17-extensions]
inline constexpr int MAX_DECIMAL32_PRECISION = 9;
^| constexpr int MAX_DECIMAL64_PRECISION = 18; | ||
| constexpr int MAX_DECIMAL128_PRECISION = 38; | ||
| inline constexpr int MAX_DECIMAL32_PRECISION = 9; | ||
| inline constexpr int MAX_DECIMAL64_PRECISION = 18; |
There was a problem hiding this comment.
warning: inline variables are a C++17 extension [clang-diagnostic-c++17-extensions]
inline constexpr int MAX_DECIMAL64_PRECISION = 18;
^| constexpr int MAX_DECIMAL128_PRECISION = 38; | ||
| inline constexpr int MAX_DECIMAL32_PRECISION = 9; | ||
| inline constexpr int MAX_DECIMAL64_PRECISION = 18; | ||
| inline constexpr int MAX_DECIMAL128_PRECISION = 38; |
There was a problem hiding this comment.
warning: inline variables are a C++17 extension [clang-diagnostic-c++17-extensions]
inline constexpr int MAX_DECIMAL128_PRECISION = 38;
^
|
Hi @happysnaker , please re-format the changes due to the check failed. See https://github.com/apache/doris/actions/runs/4890195881/jobs/8749820436?pr=19301 |
|
We're closing this PR because it hasn't been updated in a while. |
2 participants
https://en.cppreference.com/w/cpp/language/inline
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...