Skip to content

Comments

[fix](gson) avoid gson serde with EsRepository#19385

Merged
yiguolei merged 1 commit intoapache:masterfrom
morningman:es_repo_gson
May 10, 2023
Merged

[fix](gson) avoid gson serde with EsRepository#19385
yiguolei merged 1 commit intoapache:masterfrom
morningman:es_repo_gson

Conversation

@morningman
Copy link
Contributor

Proposed changes

To avoid error like:

class org.apache.doris.external.elasticsearch.EsRepository declares multiple JSON fields named runnable

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman
Copy link
Contributor Author

run buildall

@morningman
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented May 8, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.03 seconds
stream load tsv: 429 seconds loaded 74807831229 Bytes, about 166 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230509180851_clickbench_pr_141240.html

@morningman
Copy link
Contributor Author

run buildall

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 6015653 into apache:master May 10, 2023
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
To avoid error like:

class org.apache.doris.external.elasticsearch.EsRepository declares multiple JSON fields named runnable
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
To avoid error like:

class org.apache.doris.external.elasticsearch.EsRepository declares multiple JSON fields named runnable
morningman added a commit to morningman/doris that referenced this pull request May 27, 2023
To avoid error like:

class org.apache.doris.external.elasticsearch.EsRepository declares multiple JSON fields named runnable
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
To avoid error like:

class org.apache.doris.external.elasticsearch.EsRepository declares multiple JSON fields named runnable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants