Skip to content

Comments

[chore](compile) Improves PCH cache hit ratio#19469

Merged
yiguolei merged 22 commits intoapache:masterfrom
deadlinefen:deadlinefen
May 10, 2023
Merged

[chore](compile) Improves PCH cache hit ratio#19469
yiguolei merged 22 commits intoapache:masterfrom
deadlinefen:deadlinefen

Conversation

@deadlinefen
Copy link
Contributor

Problem summary

  1. Supplement the documentation of be-clion-dev, avoid the problem of undefined DORIS_JAVA_HOME and inability to find jni.h when using clion development without directly compiling through build.sh
  2. Complete the classification of header files in pch.h and introduce some header files that are not frequently modified in doris.
  3. Separate the declaration and definition in common/config.h. If you need to modify the default configuration now, please modify it in common/config.cpp.
  4. gen_cpp/version.h is regenerated every time it is recompiled, which may cause PCH to fail, so now you need to get the version information indirectly rather than directly.

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@deadlinefen
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented May 9, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.92 seconds
stream load tsv: 425 seconds loaded 74807831229 Bytes, about 167 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230510002045_clickbench_pr_141282.html

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@deadlinefen
Copy link
Contributor Author

run buildall

1 similar comment
@deadlinefen
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 10, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit a05dbd3 into apache:master May 10, 2023
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
Supplement the documentation of be-clion-dev, avoid the problem of undefined DORIS_JAVA_HOME and inability to find jni.h when using clion development without directly compiling through build.sh
Complete the classification of header files in pch.h and introduce some header files that are not frequently modified in doris.
Separate the declaration and definition in common/config.h. If you need to modify the default configuration now, please modify it in common/config.cpp.
gen_cpp/version.h is regenerated every time it is recompiled, which may cause PCH to fail, so now you need to get the version information indirectly rather than directly.
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
Supplement the documentation of be-clion-dev, avoid the problem of undefined DORIS_JAVA_HOME and inability to find jni.h when using clion development without directly compiling through build.sh
Complete the classification of header files in pch.h and introduce some header files that are not frequently modified in doris.
Separate the declaration and definition in common/config.h. If you need to modify the default configuration now, please modify it in common/config.cpp.
gen_cpp/version.h is regenerated every time it is recompiled, which may cause PCH to fail, so now you need to get the version information indirectly rather than directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/docs Categorizes issue or PR as related to documentation. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants