[Fix](Nereids) Fix minidump connect context loading and concurrency bug#19578
Merged
morrySnow merged 2 commits intoapache:masterfrom May 17, 2023
Merged
[Fix](Nereids) Fix minidump connect context loading and concurrency bug#19578morrySnow merged 2 commits intoapache:masterfrom
morrySnow merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
run buildall |
morrySnow
approved these changes
May 12, 2023
morrySnow
previously approved these changes
May 12, 2023
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run p0 |
LiBinfeng-01
force-pushed
the
fix_minidump
branch
from
77f6190 to
5eff8a9
Compare
Contributor
Author
|
run buildall |
LiBinfeng-01
force-pushed
the
fix_minidump
branch
from
5eff8a9 to
e8d8a25
Compare
Contributor
Author
|
run buildall |
morrySnow
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem summary
There are two problems of mini dump:
1、minidump do not load connect context to ThreadInfo, so it can not be get easily
2、minidump write maps with not concurrent protection, so the map size with change when we iterating map iterator
Solution:
1、loading connect context to minidump threading
2、use immutable map copy a new map before we actually doing iteration
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...