Skip to content

[bug](MTMV) Fix the wrong interpretation for NEVER REFRESH#19800

Merged
yiguolei merged 1 commit intoapache:masterfrom
adonis0147:mtmv-dev
May 18, 2023
Merged

[bug](MTMV) Fix the wrong interpretation for NEVER REFRESH#19800
yiguolei merged 1 commit intoapache:masterfrom
adonis0147:mtmv-dev

Conversation

@adonis0147
Copy link
Contributor

@adonis0147 adonis0147 commented May 18, 2023

Proposed changes

Issue Number: close #19805

Problem summary

We should pass true to the constructor method public MVRefreshInfo(boolean neverRefresh) rather than false when creating a materialized view with multiple tables which never refreshes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@adonis0147
Copy link
Contributor Author

run buildall

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 18, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit adc5522 into apache:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] NPE when creating a materialized view with multiple tables which never refreshes

2 participants

Comments