Skip to content

[chore](build) Fix the compilation errors on macOS (arm64)#19859

Merged
morningman merged 1 commit intoapache:masterfrom
adonis0147:master
May 19, 2023
Merged

[chore](build) Fix the compilation errors on macOS (arm64)#19859
morningman merged 1 commit intoapache:masterfrom
adonis0147:master

Conversation

@adonis0147
Copy link
Contributor

@adonis0147 adonis0147 commented May 19, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Some errors raise when building the codebase on macOS (arm64).

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@adonis0147
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

BiteTheDDDDt
BiteTheDDDDt previously approved these changes May 19, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 19, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@adonis0147
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 19, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@adonis0147
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@adonis0147
Copy link
Contributor Author

run be_ut

@adonis0147
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@adonis0147
Copy link
Contributor Author

run p0

2 similar comments
@adonis0147
Copy link
Contributor Author

run p0

@adonis0147
Copy link
Contributor Author

run p0

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit abde8bf into apache:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants