Skip to content

[revert](memory) revert page no use Allocator && default disable ChunkAllocator#19905

Merged
yiguolei merged 2 commits intoapache:masterfrom
xinyiZzz:20230520_fix_chunkallocator2
May 21, 2023
Merged

[revert](memory) revert page no use Allocator && default disable ChunkAllocator#19905
yiguolei merged 2 commits intoapache:masterfrom
xinyiZzz:20230520_fix_chunkallocator2

Conversation

@xinyiZzz
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

default chunk allocator reserve is 0. At this time, it is meaningless to enable chunk allocator, it will only waste memory.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xinyiZzz
Copy link
Contributor Author

run clickbench

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented May 21, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.38 seconds
stream load tsv: 412 seconds loaded 74807831229 Bytes, about 173 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 78.4 seconds inserted 10000000 Rows, about 127K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230521134728_clickbench_pr_147884.html

@xinyiZzz
Copy link
Contributor Author

run clickbench

@xinyiZzz
Copy link
Contributor Author

run buildall

@xinyiZzz
Copy link
Contributor Author

run clickbench

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 76c358b into apache:master May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants