Skip to content

Comments

[improvement](jdbc catalog)better handling of postresql bit(1) types with bool type#20022

Merged
morningman merged 4 commits intoapache:masterfrom
zy-kkk:fix_pg_bool
May 26, 2023
Merged

[improvement](jdbc catalog)better handling of postresql bit(1) types with bool type#20022
morningman merged 4 commits intoapache:masterfrom
zy-kkk:fix_pg_bool

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented May 24, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

When the postgresql bit type size is 1, it reads as a java.lang.boolean via jdbc, and if we match against string, it will display true or false. But the normal display should be a number, so when I detect that the size of bit is 1, I will match it with boolean

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zy-kkk zy-kkk changed the title [improve] (jdbc catalog) better handling of postresql bit(1) types with bool type [improvement](jdbc catalog)better handling of postresql bit(1) types with bool type May 24, 2023
@zy-kkk
Copy link
Member Author

zy-kkk commented May 24, 2023

run buildall

1 similar comment
@zgxme
Copy link
Contributor

zgxme commented May 24, 2023

run buildall

@zy-kkk
Copy link
Member Author

zy-kkk commented May 25, 2023

run buildall

@zy-kkk
Copy link
Member Author

zy-kkk commented May 25, 2023

run buildall

@zy-kkk
Copy link
Member Author

zy-kkk commented May 26, 2023

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 50ced3c into apache:master May 26, 2023
morningman pushed a commit to morningman/doris that referenced this pull request May 27, 2023
…th bool type (apache#20022)

When the postgresql bit type size is 1, it reads as a java.lang.boolean via jdbc, and if we match against string,
it will display true or false. But the normal display should be a number,
so when I detect that the size of bit is 1, I will match it with boolean
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
…th bool type (apache#20022)

When the postgresql bit type size is 1, it reads as a java.lang.boolean via jdbc, and if we match against string,
it will display true or false. But the normal display should be a number,
so when I detect that the size of bit is 1, I will match it with boolean
@zy-kkk zy-kkk deleted the fix_pg_bool branch July 28, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants