Skip to content

[Fix](multi-catalog) Fix q03 in text_external_brown regression test by handling correctly when text converter parsing error. #20190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
May 30, 2023
Merged

[Fix](multi-catalog) Fix q03 in text_external_brown regression test by handling correctly when text converter parsing error. #20190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions be/src/exec/text_converter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,41 +101,59 @@ bool TextConverter::write_vec_column(const SlotDescriptor* slot_desc,

case TYPE_BOOLEAN: {
bool num = StringParser::string_to_bool(data, len, &parse_result);
if (parse_result != StringParser::PARSE_SUCCESS) {
break;
}
reinterpret_cast<vectorized::ColumnVector<vectorized::UInt8>*>(col_ptr)
->get_data()
.resize_fill(origin_size + rows, (uint8_t)num);
break;
}
case TYPE_TINYINT: {
int8_t num = StringParser::string_to_int<int8_t>(data, len, &parse_result);
if (parse_result != StringParser::PARSE_SUCCESS) {
break;
}
reinterpret_cast<vectorized::ColumnVector<vectorized::Int8>*>(col_ptr)
->get_data()
.resize_fill(origin_size + rows, num);
break;
}
case TYPE_SMALLINT: {
int16_t num = StringParser::string_to_int<int16_t>(data, len, &parse_result);
if (parse_result != StringParser::PARSE_SUCCESS) {
break;
}
reinterpret_cast<vectorized::ColumnVector<vectorized::Int16>*>(col_ptr)
->get_data()
.resize_fill(origin_size + rows, num);
break;
}
case TYPE_INT: {
int32_t num = StringParser::string_to_int<int32_t>(data, len, &parse_result);
if (parse_result != StringParser::PARSE_SUCCESS) {
break;
}
reinterpret_cast<vectorized::ColumnVector<vectorized::Int32>*>(col_ptr)
->get_data()
.resize_fill(origin_size + rows, num);
break;
}
case TYPE_BIGINT: {
int64_t num = StringParser::string_to_int<int64_t>(data, len, &parse_result);
if (parse_result != StringParser::PARSE_SUCCESS) {
break;
}
reinterpret_cast<vectorized::ColumnVector<vectorized::Int64>*>(col_ptr)
->get_data()
.resize_fill(origin_size + rows, num);
break;
}
case TYPE_LARGEINT: {
__int128 num = StringParser::string_to_int<__int128>(data, len, &parse_result);
if (parse_result != StringParser::PARSE_SUCCESS) {
break;
}
reinterpret_cast<vectorized::ColumnVector<vectorized::Int128>*>(col_ptr)
->get_data()
.resize_fill(origin_size + rows, num);
Expand All @@ -144,13 +162,19 @@ bool TextConverter::write_vec_column(const SlotDescriptor* slot_desc,

case TYPE_FLOAT: {
float num = StringParser::string_to_float<float>(data, len, &parse_result);
if (parse_result != StringParser::PARSE_SUCCESS) {
break;
}
reinterpret_cast<vectorized::ColumnVector<vectorized::Float32>*>(col_ptr)
->get_data()
.resize_fill(origin_size + rows, num);
break;
}
case TYPE_DOUBLE: {
double num = StringParser::string_to_float<double>(data, len, &parse_result);
if (parse_result != StringParser::PARSE_SUCCESS) {
break;
}
reinterpret_cast<vectorized::ColumnVector<vectorized::Float64>*>(col_ptr)
->get_data()
.resize_fill(origin_size + rows, num);
Expand Down