Skip to content

[enhancement](publish) print detailed info for failed publish #20309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luzhijing merged 2 commits into from
Jun 1, 2023
Merged

[enhancement](publish) print detailed info for failed publish #20309

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ef28b4
(enhancement)(publish) print detailed info for failed publish
dataroaring Jun 1, 2023
08b2090
fix
dataroaring Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,16 +928,29 @@ public void finishTransaction(long transactionId, Set<Long> errorReplicaIds) thr
for (Tablet tablet : index.getTablets()) {
int healthReplicaNum = 0;
for (Replica replica : tablet.getReplicas()) {
if (!errorReplicaIds.contains(replica.getId()) && replica.getLastFailedVersion() < 0) {
if (replica.getLastFailedVersion() >= 0) {
LOG.info("publish version failed for transaction {} on tablet {},"
+ " on replica {} due to lastFailedVersion >= 0",
transactionState, tablet, replica);
continue;
}
if (!errorReplicaIds.contains(replica.getId())) {
if (replica.checkVersionCatchUp(partition.getVisibleVersion(), true)) {
++healthReplicaNum;
} else {
LOG.info("publish version failed for transaction {} on tablet {},"
+ " on replica {} due to not catchup",
transactionState, tablet, replica);
}
} else if (replica.getVersion() >= partitionCommitInfo.getVersion()) {
// the replica's version is larger than or equal to current transaction
// partition's version the replica is normal, then remove it from error replica ids
// TODO(cmy): actually I have no idea why we need this check
errorReplicaIds.remove(replica.getId());
++healthReplicaNum;
} else {
LOG.info("publish version failed for transaction {} on tablet {},"
+ " on replica {} due to version hole", transactionState, tablet, replica);
}
}

Expand Down