Skip to content

[fix](nereids)always use colocate scan in the first phase of aggregation #20695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 2 commits into from
Jun 13, 2023
Merged

[fix](nereids)always use colocate scan in the first phase of aggregation #20695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9aeef08
[fix](nereids)always use colocate scan in the first phase of aggregation
starocean999 Jun 12, 2023
1b15736
modified based on comments
starocean999 Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ public PlanFragment visitPhysicalHashAggregate(
// TODO: nereids forbid all parallel scan under aggregate temporary, because nereids could generate
// so complex aggregate plan than legacy planner, and should add forbid parallel scan hint when
// generate physical aggregate plan.
if (leftMostNode instanceof OlapScanNode && aggregate.getAggregateParam().needColocateScan) {
if (leftMostNode instanceof OlapScanNode) {
currentFragment.setHasColocatePlanNode(true);
}
setPlanRoot(currentFragment, aggregationNode, aggregate);
Expand Down
7 changes: 7 additions & 0 deletions regression-test/data/nereids_syntax_p0/aggregate_strategies.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,3 +248,10 @@ name_4 1 4
1
1

-- !sql_distinct_same_col2 --
1
1
1
1
1

3 changes: 3 additions & 0 deletions regression-test/suites/nereids_syntax_p0/aggregate_strategies.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,4 +213,7 @@ suite("aggregate_strategies") {
}

qt_sql_distinct_same_col """SELECT COUNT(DISTINCT id, id) FROM test_bucket10_table GROUP BY id """

sql "set experimental_enable_pipeline_engine=true"
qt_sql_distinct_same_col2 """SELECT COUNT(DISTINCT id, id) FROM test_bucket10_table GROUP BY id """
}