[chore](workflow) Improve the cache hit ratio in BE UT (Clang)#20871
Merged
adonis0147 merged 1 commit intoapache:masterfrom Jun 16, 2023
Merged
[chore](workflow) Improve the cache hit ratio in BE UT (Clang)#20871adonis0147 merged 1 commit intoapache:masterfrom
adonis0147 merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
In workflow
BE UT (Clang), we set up theldb_toolchainbefore we build the UT. During generating the toolchain tools, the script modifies theRPATHanddynamic linkerof the executables which making themtimeof compilers change in every build.By default, Ccache computes the hash of the compilers'
mtimeandsizeto check the compilers whether they are consistent with the ones which were used to generate the caches. If the compilers change, the caches can not be hit. We should change the default behavior of Ccache by setting the configurationcompiler_check (CCACHE_COMPILERCHECK)to increase the cache hit ratio in the workflow.Reference: https://ccache.dev/manual/latest.html#_configuration_options
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...