Skip to content

[enhancement](nereids) Add log for stats#21164

Merged
morrySnow merged 1 commit intoapache:masterfrom
Kikyou1997:eh/pip
Jun 27, 2023
Merged

[enhancement](nereids) Add log for stats#21164
morrySnow merged 1 commit intoapache:masterfrom
Kikyou1997:eh/pip

Conversation

@Kikyou1997
Copy link
Contributor

Proposed changes

  1. LOG sql when analyze failed
  2. Return directly for analyze_test suite when there is more than one frontend
  3. Set query_timeout for tpcds suites to avoid unneccessary failed caused by analyze sync

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Kikyou1997
Copy link
Contributor Author

run buildall

@Kikyou1997
Copy link
Contributor Author

run buildall

@Kikyou1997
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 26, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

SET forbid_unknown_col_stats=true;
"""

Thread.sleep(1000 * 60)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need this sleep?

return;
}
sql """
ANALYZE DATABASE ${db}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need both "analyze async" and "analyze sync" on the same db?

@morrySnow morrySnow merged commit acba864 into apache:master Jun 27, 2023
@morrySnow morrySnow added the dev/2.0.0 2.0.0 release label Jul 3, 2023
@xiaokang xiaokang added dev/2.0.0-merged and removed dev/2.0.0 2.0.0 release labels Jul 3, 2023
xiaokang pushed a commit that referenced this pull request Jul 3, 2023
1. LOG sql when analyze failed
2. Return directly for analyze_test suite when there is more than one frontend
3. Set query_timeout for tpcds suites to avoid unneccessary failed caused by analyze sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.0-merged kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments