[1.2][fix](jdbc) Handling Zero DateTime Values in Non-nullable Columns for JDBC Catalog Reading MySQL #21297
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for JDBC Catalog Reading MySQL
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
…s for JDBC Catalog Reading MySQL (apache#21297) cherry-pick from apache#21296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
cherry-pick from #21296
This pull request addresses the issue encountered when JDBC Catalog reads zero datetime values (0000-00-00 00:00:00) from non-nullable columns in MySQL. JDBC has difficulty handling such datetime format, which leads to read errors.
The proposed solution introduces the parameter zeroDateTimeBehavior=convertToNull in the jdbc_url. In this manner, when JDBC encounters 0000-00-00 00:00:00, it will convert these zero datetime values to null. Consequently, Doris will treat the DateTime column as a nullable type, allowing the read operation to proceed successfully. This change ensures data integrity and enhances read reliability when working with MySQL data sources.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...