[improvement](nererids) Don't break stats cache load loop when meeting unknown stats #21374
Closed
Kikyou1997 wants to merge 1 commit intoapache:masterfrom
Closed
[improvement](nererids) Don't break stats cache load loop when meeting unknown stats #21374Kikyou1997 wants to merge 1 commit intoapache:masterfrom
Kikyou1997 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
run buildall |
Kikyou1997
force-pushed
the
eh/forbid_unknown_stast
branch
from
178c648 to
b6998e2
Compare
Contributor
Author
|
run buildall |
Kikyou1997
changed the title
morrySnow
changed the title
morrySnow
previously approved these changes
Jul 4, 2023
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
why we cannot break the loading if some columns are unknown? |
englefly
previously approved these changes
Jul 4, 2023
Kikyou1997
force-pushed
the
eh/forbid_unknown_stast
branch
from
b6998e2 to
f81b813
Compare
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
Kikyou1997
force-pushed
the
eh/forbid_unknown_stast
branch
from
f81b813 to
0277cd5
Compare
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Analyze may got executed on master, and query may got submitted to follower, throw exception directly would break the loading for other columns.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...