-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](CCR) Binlog config is missed when create replica task #21397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](CCR) Binlog config is missed when create replica task #21397
Conversation
|
run buildall |
2 similar comments
|
run buildall |
|
run buildall |
|
TeamCity pipeline, clickbench performance test result: |
|
TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
run buildall |
|
TeamCity pipeline, clickbench performance test result: |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
JackDrogon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bug:
Binlog config is missed when create replica task.
bugfix:
add arg BinlogConfig in CreateReplicaTask()