-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improvement](memory) improve inserting sparse rows into string column #21420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
Gabriel39
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
clang-tidy review says "All clean, LGTM! 👍" |
mrhhsg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
and remove prefetch when insert data into columns, because it's effect is not stable in production env.
|
run p0 |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
and remove prefetch when insert data into columns, because it's effect is not stable in production env.
Proposed changes
Issue Number: close #xxx
For the following test, which simulate hash join outputing 435699854 rows from 5131 buiding rows:
The ColumnString::insert_indices_from inserting time improve from 6s665ms to 3s158ms:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...