[Fix](CCR) Use tableId as the credential for CCR syncer instead of tableName#21466
Merged
dataroaring merged 2 commits intoapache:masterfrom Jul 5, 2023
deadlinefen:getbinlog-table-id
Merged
[Fix](CCR) Use tableId as the credential for CCR syncer instead of tableName#21466dataroaring merged 2 commits intoapache:masterfrom deadlinefen:getbinlog-table-id
dataroaring merged 2 commits intoapache:masterfrom
deadlinefen:getbinlog-table-id
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
In the current version, CCR’s getBinlog and BeginTxn operations both depend on tableName, which will cause syncer to fail when the source cluster changes the table name.
Bugfix:
Add a tableId field in TGetBinlogRequest, and when the tableId field is set, the table field will be invalid. If the tableId field is unset, the source cluster will find the corresponding tableId based on this tableName, and this operation should only be used when initializing syncer.