[bugfix](RowsetIterator) use valid stats when creating segment iterator #21512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Tanya-W
reviewed
Jul 5, 2023
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
PR approved by anyone and no changes requested. |
ByteYue
force-pushed
the
use_stats_when_not_query
branch
from
e5a96ba to
64804df
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The former logic would directly use read_context as segment iterator's _context
_context = read_context;. But if it's invoked by schema change or compaction, it would pass one read_context whose stats is nullptr like the following picture.Thus the following file cache statistics assignation would get one invalid address
_read_options.io_ctx.file_cache_stats = &read_context->stats->file_cache_stats;which would be the offset for file_cache_stats in stats.This pr would make the read_context->stats always valid to prevent such coredump.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...