Skip to content

Conversation

@zhangy5
Copy link
Contributor

@zhangy5 zhangy5 commented Jul 13, 2023

Proposed changes

add partition table case:

  1. different column types as partition key (p0)
  2. create partition table error msg (p0)
  3. add/drop partition (p1)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zhangy5
Copy link
Contributor Author

zhangy5 commented Jul 13, 2023

run buildall

@zhangy5 zhangy5 force-pushed the partition_table_case branch from 1e2554f to fa8e0eb Compare July 14, 2023 02:16
Copy link
Contributor

@luozenglin luozenglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 18, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@adonis0147 adonis0147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangy5 zhangy5 force-pushed the partition_table_case branch from fa8e0eb to 4762fd5 Compare July 19, 2023 03:42
@adonis0147
Copy link
Contributor

run buildall

Copy link
Contributor

@adonis0147 adonis0147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei added the dev/2.0.0 2.0.0 release label Jul 19, 2023
@luozenglin luozenglin merged commit 56c67a4 into apache:master Jul 19, 2023
@zhangy5 zhangy5 deleted the partition_table_case branch July 19, 2023 06:12
@xiaokang xiaokang added dev/2.0.0-merged and removed dev/2.0.0 2.0.0 release labels Jul 20, 2023
LHG41278 pushed a commit to LHG41278/dorisMine that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.0-merged kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants