[Improvement](pipeline) support send eos on local exchange and remove some unused code#22086
Conversation
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
| SCOPED_CONSUME_MEM_TRACKER(_parent->_mem_tracker.get()); | ||
| status = send_block((PBlock*)nullptr, true); | ||
| if (is_local()) { | ||
| if (_recvr_is_valid()) { |
There was a problem hiding this comment.
if just remove the sender not send a null block to receiver. Then the receiver may not get eof signal?
There was a problem hiding this comment.
The receiver just judge the eof by sender_number == 0;
… some unused code (#22086) support send eos on local exchange and remove some unused code
Proposed changes
support send eos on local exchange and remove some unused code
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...