[bugfix](be core) fragment executor's destruct method should be called before query context#22362
[bugfix](be core) fragment executor's destruct method should be called before query context#22362yiguolei merged 2 commits intoapache:masterfrom
Conversation
…d before query context
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
PR approved by anyone and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
…d before query context (#22362) fragment executor's destruct method will call close, it depends on query context's object pool, because many object is put in query context's object pool such as runtime filter. It should be deleted before query context. Or there will be heap use after free error. It is fixed in #17675, but Do not know why not in master. So 1.2-lts does not have this problem. --------- Co-authored-by: yiguolei <yiguolei@gmail.com>
5 participants
Proposed changes
It is fixed in #17675, but Do not know why not in master. So 1.2-lts does not have this problem.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...