[fix](stacktrace) Fix Jemalloc enable profile fail to run BE after rewrites dl_iterate_phdr.#22549
Merged
xinyiZzz merged 1 commit intoapache:masterfrom Aug 3, 2023
Merged
Conversation
xinyiZzz
changed the title
dl_iterate_phdr.dl_iterate_phdr.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
xiaokang
pushed a commit
to xiaokang/doris
that referenced
this pull request
Aug 9, 2023
…writes dl_iterate_phdr (apache#22549) Jemalloc heap profile follows libgcc's way of backtracing by default. rewrites dl_iterate_phdr will cause Jemalloc to fail to run after enable profile. TODO, two solutions: - Jemalloc specifies GNU libunwind as the prof backtracing way, but my test failed, --enable-prof-libunwind not work: --enable-prof-libunwind not work jemalloc/jemalloc#2504 - ClickHouse/libunwind solves Jemalloc profile backtracing, but the branch of ClickHouse/libunwind has been out of touch with GNU libunwind and LLVM libunwind, which will leave the fate to others.
xiaokang
pushed a commit
that referenced
this pull request
Aug 11, 2023
…writes dl_iterate_phdr (#22549) Jemalloc heap profile follows libgcc's way of backtracing by default. rewrites dl_iterate_phdr will cause Jemalloc to fail to run after enable profile. TODO, two solutions: - Jemalloc specifies GNU libunwind as the prof backtracing way, but my test failed, --enable-prof-libunwind not work: --enable-prof-libunwind not work jemalloc/jemalloc#2504 - ClickHouse/libunwind solves Jemalloc profile backtracing, but the branch of ClickHouse/libunwind has been out of touch with GNU libunwind and LLVM libunwind, which will leave the fate to others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jemalloc heap profile follows libgcc's way of backtracing by default.
rewrites dl_iterate_phdr will cause Jemalloc to fail to run after enable profile.
TODO, two solutions:
--enable-prof-libunwindnot work:--enable-prof-libunwindnot work jemalloc/jemalloc#2504has been out of touch with GNU libunwind and LLVM libunwind, which will leave the fate to others.
Maybe the error of jeprof dump profile can also be solved
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...