Skip to content

Comments

[Bug](exchange) change BlockSerializer from unique_ptr to object#22653

Merged
BiteTheDDDDt merged 2 commits intoapache:masterfrom
BiteTheDDDDt:fix_0807
Aug 7, 2023
Merged

[Bug](exchange) change BlockSerializer from unique_ptr to object#22653
BiteTheDDDDt merged 2 commits intoapache:masterfrom
BiteTheDDDDt:fix_0807

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Aug 7, 2023

Proposed changes

_serializer is nullptr will cause core dump.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Aug 7, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Aug 7, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 7, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.84 seconds
stream load tsv: 511 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162513407 Bytes

Gabriel39
Gabriel39 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 591aee5 into apache:master Aug 7, 2023
@BiteTheDDDDt BiteTheDDDDt deleted the fix_0807 branch January 20, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriel39 Gabriel39 Gabriel39 approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BiteTheDDDDt @hello-stephen @Gabriel39 @zhangstar333