Skip to content

[Chore](RoutineLoad)Change max_batch_interval minimum limit from 5 to 1#22858

Merged
zy-kkk merged 1 commit intoapache:masterfrom
CalvinKirs:master-routine-load-limit
Aug 11, 2023
Merged

[Chore](RoutineLoad)Change max_batch_interval minimum limit from 5 to 1#22858
zy-kkk merged 1 commit intoapache:masterfrom
CalvinKirs:master-routine-load-limit

Conversation

@CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Aug 11, 2023

In some business scenarios, users want lower latency. We have tested that routineload can work well even if it is set to 1s when the concurrency is not high.

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@CalvinKirs
Copy link
Member Author

run buildall

@CalvinKirs
Copy link
Member Author

run clickbench-new (clickbench)

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.23 seconds
stream load tsv: 514 seconds loaded 74807831229 Bytes, about 138 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162324288 Bytes

Copy link
Contributor

@sollhui sollhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 11, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@zy-kkk zy-kkk merged commit caf496a into apache:master Aug 11, 2023
@CalvinKirs CalvinKirs deleted the master-routine-load-limit branch August 11, 2023 04:02
CalvinKirs added a commit to CalvinKirs/incubator-doris that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants