[Pipeline](exec) support async writer in pipelien query engine#22901
[Pipeline](exec) support async writer in pipelien query engine#22901Gabriel39 merged 1 commit intoapache:masterfrom
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
| } | ||
|
|
||
| void AsyncResultWriter::start_writer() { | ||
| ExecEnv::GetInstance()->fragment_mgr()->get_thread_pool()->submit_func( |
There was a problem hiding this comment.
Maybe this need a lot of threads
There was a problem hiding this comment.
I think we need another thread pool with a configurable size
HappenLee
changed the title
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
| } | ||
|
|
||
| void AsyncResultWriter::start_writer() { | ||
| ExecEnv::GetInstance()->fragment_mgr()->get_thread_pool()->submit_func( |
There was a problem hiding this comment.
I think we need another thread pool with a configurable size
|
|
||
| void AsyncResultWriter::process_block() { | ||
| if (!_is_open) { | ||
| _writer_status = open(); |
There was a problem hiding this comment.
process_block will not be executed twice so we do not need to do this check
5 participants
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...