[Enhancement] BE webserver support SSL #22971#22972
Closed
LuGuangming wants to merge 23 commits intoapache:masterfrom
LuGuangming:master
Closed
[Enhancement] BE webserver support SSL #22971#22972LuGuangming wants to merge 23 commits intoapache:masterfrom LuGuangming:master
LuGuangming wants to merge 23 commits intoapache:masterfrom
LuGuangming:master
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
reviewed
Aug 15, 2023
be/src/http/ev_http_server.h
Outdated
| private: | ||
| Status _bind(); | ||
| HttpHandler* _find_handler(HttpRequest* req); | ||
| void _Init(); |
Contributor
There was a problem hiding this comment.
_Init()---> _init_ssl()
_ServerSetCerts(); --> _server_set_certs()
yiguolei
reviewed
Aug 15, 2023
| } | ||
| _event_bases.clear(); | ||
| } | ||
| if (m_ctx != NULL) { |
…port enclose and escape for stream load (#22539) ## Proposed changes Refactor thoughts: close #22383 Descriptions about `enclose` and `escape`: #22385 ## Further comments 2023-08-09: It's a pity that experiment shows that the original way for parsing plain CSV is faster. Therefor, the refactor is only applied on enclose related code. The plain CSV parser use the original logic. Fallback of performance is unavoidable anyway. From the `CSV reader`'s perspective, the real weak point may be the write column behavior, proved by the flame graph. Trimming escape will be enable after fix: #22411 is merged Cases should be discussed: 1. When an incomplete enclose appears in the beginning of a large scale data, the line delimiter will be unreachable till the EOF, will the buffer become extremely large? 2. What if an infinite line occurs in the case? Essentially, `1.` is equivalent to this. Only support stream load as trial in this PR, avoid too many unrelated changes. Docs will be added when `enclose` and `escape` is available for all kinds of load.
fix if function not handle const nullable value
…ITIONED shuffle (#22973) fix wrong result of BUCKET_SHFFULE_HASH_PARTITIONED shuffle
change some log fatal and dcheck to exception
In the map_agg handler function, added the judgment on columns[1]->is_nullable()
…ile sink (#22902) type check could not work because no expression in plan. sink and scan have no expression at all. so cannot check type. this pr add expression on logical sink to let type check work well
init _instance_to_rpc_ctx on register_sink
…rquet write (#22792) before the parquet write export decimal as byte-binary, but can't be import those fied to Hive. Now, change to export decimal as fixed-len-byte-array in order to import hive directly.
Currently, we only return ambiguous "INTERNAL ERROR" to the user when load. This commit will no more hide the root cause. Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
support GRANT privilege[(col1,col2...)] [, privilege] ON db.tbl TO user_identity [ROLE 'role'];
…rt-circuit-read. (#22697) Sometimes the BEs will be deployed on the same node with DataNode, so we can use a more reasonable BE selection policy to use the hdfs short-circuit-read as much as possible.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #22971
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...