Skip to content

[fix](inverted index change) make mutex for ALTER_INVERTED_INDEX task and STORAGE_MEDIUM_MIGRATE task#22995

Merged
xiaokang merged 2 commits intoapache:masterfrom
Tanya-W:fix
Aug 18, 2023
Merged

[fix](inverted index change) make mutex for ALTER_INVERTED_INDEX task and STORAGE_MEDIUM_MIGRATE task#22995
xiaokang merged 2 commits intoapache:masterfrom
Tanya-W:fix

Conversation

@Tanya-W
Copy link
Contributor

@Tanya-W Tanya-W commented Aug 15, 2023 •
edited
Loading

Proposed changes

make mutex for ALTER_INVERTED_INDEX task and STORAGE_MEDIUM_MIGRATE task

branch-2.0 pr #23033

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Tanya-W
Copy link
Contributor Author

Tanya-W commented Aug 15, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

clang-tidy review says "All clean, LGTM! 👍"

xiaokang
xiaokang previously approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang
Copy link
Contributor

xiaokang commented Aug 15, 2023

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

PR approved by anyone and no changes requested.

@Tanya-W
Copy link
Contributor Author

Tanya-W commented Aug 15, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

clang-tidy review says "All clean, LGTM! 👍"

@Tanya-W
Copy link
Contributor Author

Tanya-W commented Aug 15, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

clang-tidy review says "All clean, LGTM! 👍"

zzzxl1993
zzzxl1993 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang xiaokang mentioned this pull request Aug 17, 2023
Merged
@Tanya-W
Copy link
Contributor Author

Tanya-W commented Aug 17, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 17, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.76 seconds
stream load tsv: 536 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162120544 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

PR approved by at least one committer and no changes requested.

@xiaokang xiaokang merged commit de98324 into apache:master Aug 18, 2023
@Tanya-W Tanya-W deleted the fix branch September 12, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokang xiaokang xiaokang approved these changes

@zzzxl1993 zzzxl1993 zzzxl1993 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tanya-W @xiaokang @hello-stephen @zzzxl1993

Comments