[Performance](status code) improve the status code performance#23318
Closed
bobhan1 wants to merge 1 commit intoapache:masterfrom
Closed
[Performance](status code) improve the status code performance#23318bobhan1 wants to merge 1 commit intoapache:masterfrom
bobhan1 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
reviewed
Aug 23, 2023
| DCHECK(_pk_index_reader != nullptr); | ||
| if (!_pk_index_reader->check_present(key_without_seq)) { | ||
| return Status::NotFound("Can't find key in the segment"); | ||
| return Status::NotFound(""); |
Contributor
There was a problem hiding this comment.
Is this pr will really improve performance???
Could you please provide some performance number?
bobhan1
force-pushed
the
improve-status-code
branch
from
804f1ca to
c3214ef
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
run buildall |
Contributor
Author
I misuse the ASAN build to do profiling and get the wrong result |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...