Skip to content

[Improvement](Slice) support move constructor and operator for Slice#23694

Merged
yiguolei merged 3 commits intoapache:masterfrom
sollhui:slice
Sep 1, 2023
Merged

[Improvement](Slice) support move constructor and operator for Slice#23694
yiguolei merged 3 commits intoapache:masterfrom
sollhui:slice

Conversation

@sollhui
Copy link
Copy Markdown
Contributor

@sollhui sollhui commented Aug 31, 2023

Proposed changes

The purpose of supporting move constructor and operator for Slice:

  • Supporting move construction allows for more flexible selection of construction strategies and ensure memory ownership.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@sollhui
Copy link
Copy Markdown
Contributor Author

sollhui commented Aug 31, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.5 seconds
stream load tsv: 545 seconds loaded 74807831229 Bytes, about 130 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162232576 Bytes

@sollhui
Copy link
Copy Markdown
Contributor Author

sollhui commented Aug 31, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.86 seconds
stream load tsv: 532 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162238116 Bytes

Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 1, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 1, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 1, 2023

PR approved by anyone and no changes requested.

@sollhui sollhui changed the title [Improvement](Slice) support mobile constructor and operator for Slice [Improvement](Slice) support move constructor and operator for Slice Sep 1, 2023
Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit e0efda1 into apache:master Sep 1, 2023
@sollhui sollhui deleted the slice branch September 28, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants