Skip to content

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Sep 1, 2023

Proposed changes

after eliminate outer join, create is-not-null predicate, and then this is-not-null predicate can be used to eliminate descendant outer join. the newly created is-not-null predicate will be eliminated in EliminateNotNull rule.

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@englefly englefly marked this pull request as ready for review September 1, 2023 09:00
@englefly englefly changed the title is not null [feature](nereids) eliminate cascading outer join Sep 1, 2023
@englefly
Copy link
Contributor Author

englefly commented Sep 1, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.32 seconds
stream load tsv: 534 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162076781 Bytes

@englefly
Copy link
Contributor Author

englefly commented Sep 4, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.6 seconds
stream load tsv: 531 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17161895421 Bytes

}

private static final class JoinSlotCoverageChecker {
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add this into case track

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

PR approved by at least one committer and no changes requested.

@englefly englefly merged commit 5dc46ef into apache:master Sep 4, 2023
@englefly englefly deleted the is-not-null branch September 4, 2023 08:00
@morrySnow morrySnow added dev/2.0.2 usercase Important user case type label not-merge/2.0 do not merge into 2.0 branch and removed dev/2.0.2 labels Sep 8, 2023
englefly added a commit to englefly/incubator-doris that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. not-merge/2.0 do not merge into 2.0 branch reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants