Skip to content

[Enhancement](build) try to download commit specific source code when git submodule failed#23846

Merged
qidaye merged 2 commits intoapache:masterfrom
airborne12:fix-build
Sep 4, 2023
Merged

[Enhancement](build) try to download commit specific source code when git submodule failed#23846
qidaye merged 2 commits intoapache:masterfrom
airborne12:fix-build

Conversation

@airborne12
Copy link
Member

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In build.sh line 286:
        local submodule_commit=$(git ls-tree HEAD ${submodule_path} | awk '{print $3}')
              ^--------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                                  ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        local submodule_commit=$(git ls-tree HEAD "${submodule_path}" | awk '{print $3}')


In build.sh line 288:
        local commit_specific_url=$(echo "${archive_url}" | sed "s/refs\/heads/${submodule_commit}/")
              ^-----------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.

For more information:
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt ' found no issues.

@airborne12
Copy link
Member Author

run buildall

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.8 seconds
stream load tsv: 534 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17161953930 Bytes

Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit 7727535 into apache:master Sep 4, 2023
xiaokang pushed a commit that referenced this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants