Skip to content

[fix](intersect) fix wrong result of intersect node#24044

Merged
yiguolei merged 1 commit intoapache:masterfrom
jacktengg:fix-intersect
Sep 8, 2023
Merged

[fix](intersect) fix wrong result of intersect node#24044
yiguolei merged 1 commit intoapache:masterfrom
jacktengg:fix-intersect

Conversation

@jacktengg
Copy link
Contributor

@jacktengg jacktengg commented Sep 7, 2023 •
edited
Loading

Proposed changes

Issue Number: close #24046

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@jacktengg
Copy link
Contributor Author

jacktengg commented Sep 7, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Sep 7, 2023

TeamCity be ut coverage result:
Function Coverage: 37.02% (7887/21307)
Line Coverage: 29.03% (63329/218185)
Region Coverage: 27.92% (32871/117728)
Branch Coverage: 24.50% (16887/68918)
Coverage Report: http://coverage.selectdb-in.cc/coverage/51e76cdad2351008a57c5e183c05babf7df805f6_51e76cdad2351008a57c5e183c05babf7df805f6/report/index.html

@doris-robot
Copy link

doris-robot commented Sep 7, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.41 seconds
stream load tsv: 531 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162177362 Bytes

HappenLee
HappenLee reviewed Sep 7, 2023
View reviewed changes
be/src/vec/exec/vset_operation_node.cpp

if constexpr (is_intersect) { //intersected
if (it->visited) {
it->visited = false;
Copy link
Contributor

@HappenLee HappenLee Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to the work

Copy link
Contributor Author

@jacktengg jacktengg Sep 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean reset the visited flag? For intersect, clear the visited flag is necessary, since the new inserted iter->get_value() will have the value of it->visited.

HappenLee
HappenLee approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

PR approved by anyone and no changes requested.

yiguolei
yiguolei approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit b73f345 into apache:master Sep 8, 2023
@jacktengg jacktengg deleted the fix-intersect branch September 8, 2023 06:46
xiaokang pushed a commit that referenced this pull request Sep 8, 2023
@jacktengg @xiaokang
[fix](intersect) fix wrong result of intersect node (#24044)
df064d1 
Issue Number: close #24046
xiaokang added a commit that referenced this pull request Sep 8, 2023
@xiaokang
fix be compile error for df064d1
549d188 
[fix](intersect) fix wrong result of intersect node (#24044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.2-merged merge_conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Doirs INTERSECT 结果错误

6 participants

@jacktengg @doris-robot @yiguolei @HappenLee @xiaokang @morningman

Comments