Skip to content

[Fix](autobucket) use single replica partition size to calc bucket number#24045

Merged
yiguolei merged 1 commit intoapache:masterfrom
cambyzju:fix-auto-bucket
Sep 8, 2023
Merged

[Fix](autobucket) use single replica partition size to calc bucket number#24045
yiguolei merged 1 commit intoapache:masterfrom
cambyzju:fix-auto-bucket

Conversation

@cambyzju
Copy link
Contributor

@cambyzju cambyzju commented Sep 7, 2023

Proposed changes

Issue Number: close #xxx

Now we use partition size to calculate bucket number for auto bucket.

Partition size should use single replica size instead of sum of all replicas.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@cambyzju
Copy link
Contributor Author

cambyzju commented Sep 7, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.94 seconds
stream load tsv: 533 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162149162 Bytes

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

PR approved by anyone and no changes requested.

Copy link
Contributor

@luozenglin luozenglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 84c1f56 into apache:master Sep 8, 2023
cambyzju pushed a commit to cambyzju/incubator-doris that referenced this pull request Sep 11, 2023
morningman pushed a commit that referenced this pull request Sep 11, 2023
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments