Skip to content

[Fix](MemtableMemoryLimiter) Fix memtable memory limiter tigger flush log#24137

Merged
dataroaring merged 2 commits intoapache:masterfrom
sollhui:memlimiter
Sep 10, 2023
Merged

[Fix](MemtableMemoryLimiter) Fix memtable memory limiter tigger flush log#24137
dataroaring merged 2 commits intoapache:masterfrom
sollhui:memlimiter

Conversation

@sollhui
Copy link
Contributor

@sollhui sollhui commented Sep 9, 2023

Proposed changes

Fix memtable memory limiter tigger flush log, "reached the load hard limit" is error.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@sollhui
Copy link
Contributor Author

sollhui commented Sep 9, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@sollhui sollhui changed the title [Fix](Memory) Fix memtable memory limiter tigger flush log [Fix](MemtableMemoryLimiter) Fix memtable memory limiter tigger flush log Sep 9, 2023
@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.4 seconds
stream load tsv: 534 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161940621 Bytes

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 10, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@sollhui
Copy link
Contributor Author

sollhui commented Sep 10, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.94% (7911/21415)
Line Coverage: 28.96% (63554/219446)
Region Coverage: 27.90% (32997/118282)
Branch Coverage: 24.47% (16953/69276)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f99e8f2d001104dd6eb1cf52163a5661ad472cad_f99e8f2d001104dd6eb1cf52163a5661ad472cad/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.73 seconds
stream load tsv: 584 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162188035 Bytes

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 648bf77 into apache:master Sep 10, 2023
@sollhui sollhui deleted the memlimiter branch September 28, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments