Skip to content

[Bug](function) fix explode_json_array_int can't handle min/max values#24284

Merged
yiguolei merged 1 commit intoapache:masterfrom
zhangstar333:udf_log
Sep 14, 2023
Merged

[Bug](function) fix explode_json_array_int can't handle min/max values#24284
yiguolei merged 1 commit intoapache:masterfrom
zhangstar333:udf_log

Conversation

@zhangstar333
Copy link
Contributor

Proposed changes

the json str get value maybe beyond max/min of Int64,
so add some check to limit the value, and return the max/min of Int64

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zhangstar333
Copy link
Contributor Author

run buildall

Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 13, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju
Copy link
Contributor

better also add some hint in docs.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.93% (7940/21500)
Line Coverage: 28.93% (63705/220241)
Region Coverage: 27.87% (33094/118724)
Branch Coverage: 24.44% (16984/69494)
Coverage Report: http://coverage.selectdb-in.cc/coverage/82c03af3d97a2041d78943d5d152fde7f16125ed_82c03af3d97a2041d78943d5d152fde7f16125ed/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.73 seconds
stream load tsv: 593 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162346368 Bytes

@ixzc ixzc mentioned this pull request Sep 13, 2023
3 tasks
@zhangstar333
Copy link
Contributor Author

run p0

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 9b7f041 into apache:master Sep 14, 2023
xiaokang pushed a commit that referenced this pull request Sep 14, 2023
#24284)

the json str get value maybe beyond max/min of Int64,
so add some check to limit the value, and return the max/min of Int64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants