[Fix](S3 tvf) fix that S3 tvf can not run properly #24289
Merged
morningman merged 1 commit intoapache:masterfrom Sep 14, 2023
Merged
[Fix](S3 tvf) fix that S3 tvf can not run properly #24289morningman merged 1 commit intoapache:masterfrom
morningman merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Contributor
Author
|
run p1 |
morningman
reviewed
Sep 13, 2023
Contributor
morningman
left a comment
There was a problem hiding this comment.
Need to add regression test
morningman
approved these changes
Sep 14, 2023
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
xiaokang
pushed a commit
to xiaokang/doris
that referenced
this pull request
Sep 27, 2023
This bug is caused by this PR: apache#23635
xiaokang
pushed a commit
that referenced
this pull request
Oct 3, 2023
This bug is caused by this PR: #23635
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
bug describe
There will be an error althouth when we use correctness S3 properties:
Reson
This bug is caused by this PR: #23635
Because the
Broker constructorwill change the incoming parameters——propertiesbefore #23635 :The parameter
propertieswill be changed atthis.properties.putAll(S3ClientBEProperties.getBeFSProperties(this.properties));becausethis.propertiesandpropertiesare point to the same reference.But
propertieswill not be changed in PR #23635Howerver, the member
locationPropertiesofS3TableValuedFunctionrely on this change. So we get this bugFurther comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...