Skip to content

[fix](io): use try with resource make io stream close automatically to avoid resource leak#24605

Merged
yiguolei merged 1 commit intoapache:masterfrom
xutaoustc:issueFix
Sep 20, 2023
Merged

[fix](io): use try with resource make io stream close automatically to avoid resource leak#24605
yiguolei merged 1 commit intoapache:masterfrom
xutaoustc:issueFix

Conversation

@xutaoustc
Copy link
Contributor

Some code are scanned to have potential security and performance problems:
This pr fix the problem that some iostream are not closed after using.
Use try with resource make io stream close automatically to avoid resource leak

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 20, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.08 seconds
stream load tsv: 604 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162478064 Bytes

@yiguolei yiguolei merged commit b7ca4fc into apache:master Sep 20, 2023
JingDas pushed a commit to JingDas/doris that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants