Skip to content

[fix](planner) statement run successful but log error msg in audit log#24628

Merged
yiguolei merged 1 commit into
apache:masterfrom
morrySnow:fix_audit_log
Sep 20, 2023
Merged

[fix](planner) statement run successful but log error msg in audit log#24628
yiguolei merged 1 commit into
apache:masterfrom
morrySnow:fix_audit_log

Conversation

@morrySnow
Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

legacy planner will set error msg when throw AnalysisException.
However, in some place, we catch these exception and muted them.
So, we should reset back error msg and error code.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
Copy link
Copy Markdown
Contributor Author

run buildall

@morrySnow morrySnow added usercase Important user case type label dev/1.2.8 dev/2.0.3 labels Sep 19, 2023
@doris-robot
Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.48 seconds
stream load tsv: 601 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162486382 Bytes

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Sep 20, 2023
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit b02398b into apache:master Sep 20, 2023
@morrySnow morrySnow deleted the fix_audit_log branch September 20, 2023 04:20
JingDas pushed a commit to JingDas/doris that referenced this pull request Sep 20, 2023
apache#24628)

legacy planner will set error msg when throw AnalysisException.
However, in some place, we catch these exception and muted them.
So, we should reset back error msg and error code.
xiaokang pushed a commit to xiaokang/doris that referenced this pull request Sep 27, 2023
apache#24628)

legacy planner will set error msg when throw AnalysisException.
However, in some place, we catch these exception and muted them.
So, we should reset back error msg and error code.
xiaokang pushed a commit that referenced this pull request Oct 3, 2023
#24628)

legacy planner will set error msg when throw AnalysisException.
However, in some place, we catch these exception and muted them.
So, we should reset back error msg and error code.
morningman pushed a commit that referenced this pull request Oct 7, 2023
#24628)

legacy planner will set error msg when throw AnalysisException.
However, in some place, we catch these exception and muted them.
So, we should reset back error msg and error code.
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Dec 11, 2023
apache#24628)

legacy planner will set error msg when throw AnalysisException.
However, in some place, we catch these exception and muted them.
So, we should reset back error msg and error code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/1.2.8-merged dev/2.0.3-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants