Skip to content

[Chore](dependency)grpc library dependencies are unified#24794

Merged
zy-kkk merged 1 commit intoapache:masterfrom
CalvinKirs:docs-for-start
Sep 23, 2023
Merged

[Chore](dependency)grpc library dependencies are unified#24794
zy-kkk merged 1 commit intoapache:masterfrom
CalvinKirs:docs-for-start

Conversation

@CalvinKirs
Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs commented Sep 22, 2023

backend

The grpc dependency should slimmed down and unified. I noticed A, but currently we include the netty dependency and the version is unique, and the classes of the two versions are exactly the same. So it's not a problem
#8264

Issue Number: close #xxx

change

Remove grpc-netty-shade library

test

fc616689-524d-44b9-b8b5-141f660c59fa

@CalvinKirs
Copy link
Copy Markdown
Member Author

run buildall

@doris-robot
Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.81 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162207463 Bytes

Copy link
Copy Markdown
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Sep 23, 2023
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@zy-kkk zy-kkk merged commit ce8dfd3 into apache:master Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants