Skip to content

[Bug](pipeline) nullprt may be close the sink if init failed#24926

Merged
yiguolei merged 1 commit intoapache:masterfrom
HappenLee:bug
Sep 27, 2023
Merged

[Bug](pipeline) nullprt may be close the sink if init failed#24926
yiguolei merged 1 commit intoapache:masterfrom
HappenLee:bug

Conversation

@HappenLee
Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@HappenLee
Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Sep 26, 2023
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.27 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162241700 Bytes

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.33% (8142/22413)
Line Coverage: 28.44% (65160/229096)
Region Coverage: 27.41% (33792/123303)
Branch Coverage: 24.07% (17250/71672)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d5a5cb718014b2ffcd52e488931ed1b6274d8283_d5a5cb718014b2ffcd52e488931ed1b6274d8283/report/index.html

Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 24ee360 into apache:master Sep 27, 2023
vinlee19 pushed a commit to vinlee19/doris that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants