Skip to content

Comments

[fix](es-catalog)fix es http timeout#25273

Merged
qidaye merged 1 commit intoapache:masterfrom
liugddx:bugfix-12
Oct 12, 2023
Merged

[fix](es-catalog)fix es http timeout#25273
qidaye merged 1 commit intoapache:masterfrom
liugddx:bugfix-12

Conversation

@liugddx
Copy link
Member

@liugddx liugddx commented Oct 10, 2023

Proposed changes

Issue Number: close #xxx

image

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@liugddx
Copy link
Member Author

liugddx commented Oct 10, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 10, 2023

TeamCity be ut coverage result:
Function Coverage: 36.32% (8151/22444)
Line Coverage: 28.44% (65189/229224)
Region Coverage: 27.37% (33785/123440)
Branch Coverage: 24.04% (17216/71602)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5bcfac04d85d354c8169ca6c5397d02dcd9982ba_5bcfac04d85d354c8169ca6c5397d02dcd9982ba/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 10, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.87 seconds
stream load tsv: 562 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162262845 Bytes

morningman
morningman approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

PR approved by anyone and no changes requested.

qidaye
qidaye approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit 2014e16 into apache:master Oct 12, 2023
xiaokang pushed a commit that referenced this pull request Oct 12, 2023
@liugddx @xiaokang
[fix](es catalog)fix es http timeout (#25273)
5300b79
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@liugddx
[fix](es catalog)fix es http timeout (apache#25273)
f8b210b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@qidaye qidaye qidaye approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liugddx @doris-robot @morningman @qidaye @xiaokang